On Thu, Apr 27, 2017 at 02:20:21PM -0400, Jeff Moyer wrote: > Hi, Christoph, > > Christoph Hellwig <hch@xxxxxx> writes: > > > Remove the request_idx parameter, which can't be used safely now that we > > support I/O schedulers with blk-mq. Except for a superflous check in > > mtip32xx it was unused anyway. > > I'm not sure how your patch builds. If I look at the mtip32xx driver in > for-4.12/post-merge, I see this: Meh, you're right. It did build fine when I tested it based on Jens' for-4.12/block + my nvme PR. But it seems like the post-merge merge branch doesn't have the previous mtip32xxx fix yet that is a prerequisite for this change. Jens: any idea why? I'm getting lost in the maze of branches.. > If you got rid of request_idx, then this shouldn't build. So, is there > some other prerequisite patch I'm missing? Yes, both you and I are. It's "mtip32xx: use runtime tag to initialize command header" which is in Jens' for-4.12/block tree, but not in the post-merge one. > > Note that the patch that introduced the request_idx check fixed a bug, > where module load would walk off the end of an array. See commit > 74c9c9134bf8. Yes, but that behavior is gone with the above patch, which was necessary to support blk-mq I/O schedulers.
