On 04/28/2017 08:09 AM, Christoph Hellwig wrote: > On Thu, Apr 27, 2017 at 02:20:21PM -0400, Jeff Moyer wrote: >> Hi, Christoph, >> >> Christoph Hellwig <hch@xxxxxx> writes: >> >>> Remove the request_idx parameter, which can't be used safely now that we >>> support I/O schedulers with blk-mq. Except for a superflous check in >>> mtip32xx it was unused anyway. >> >> I'm not sure how your patch builds. If I look at the mtip32xx driver in >> for-4.12/post-merge, I see this: > > Meh, you're right. It did build fine when I tested it based on Jens' > for-4.12/block + my nvme PR. But it seems like the post-merge merge > branch doesn't have the previous mtip32xxx fix yet that is a prerequisite > for this change. Jens: any idea why? I'm getting lost in the maze > of branches.. There are only two branches :-) I'll rebase the post-merge one, that's basically just for me to sync. But it doesn't help that they are moving apart. I'll do that now. If you can review the mtip32xx stuff, then we can have one happy base in post-merge that can take further work on top of that. -- Jens Axboe
