Re: [PATCH 2/2] block: don't make REQ_POLLED imply REQ_NOWAIT

[Bart Van Assche <bvanassche@xxxxxxx>]

On 8/8/23 10:13, Jens Axboe wrote:
> diff --git a/include/linux/bio.h b/include/linux/bio.h
> index c4f5b5228105..11984ed29cb8 100644
> --- a/include/linux/bio.h
> +++ b/include/linux/bio.h
> @@ -791,7 +791,7 @@ static inline int bio_integrity_add_page(struct bio *bio, struct page *page,
>   static inline void bio_set_polled(struct bio *bio, struct kiocb *kiocb)
>   {
>   	bio->bi_opf |= REQ_POLLED;
> -	if (!is_sync_kiocb(kiocb))
> +	if (kiocb->ki_flags & IOCB_NOWAIT)
>   		bio->bi_opf |= REQ_NOWAIT;
>   }

The implementation of bio_set_polled() is short and that function has
only one caller. Has it been considered to inline that function into
its caller?

Thanks,

Bart.