On 8/8/23 3:58?PM, Bart Van Assche wrote:
> On 8/8/23 10:13, Jens Axboe wrote:
>> diff --git a/include/linux/bio.h b/include/linux/bio.h
>> index c4f5b5228105..11984ed29cb8 100644
>> --- a/include/linux/bio.h
>> +++ b/include/linux/bio.h
>> @@ -791,7 +791,7 @@ static inline int bio_integrity_add_page(struct bio *bio, struct page *page,
>> static inline void bio_set_polled(struct bio *bio, struct kiocb *kiocb)
>> {
>> bio->bi_opf |= REQ_POLLED;
>> - if (!is_sync_kiocb(kiocb))
>> + if (kiocb->ki_flags & IOCB_NOWAIT)
>> bio->bi_opf |= REQ_NOWAIT;
>> }
>
> The implementation of bio_set_polled() is short and that function has
> only one caller. Has it been considered to inline that function into
> its caller?
I think it should probably just go away, but wanted to leave that for a
non-functional cleanup (which can wait for 6.6).
--
Jens Axboe
