On Jul 26, 2023 / 14:46, Daniel Wagner wrote: > Max asked me to replace replace the 'nvme/rc: Avoid triggering host nvme-cli > autoconnect' feature with using allowed_host on the target side [1] > > So while looking into this new feature, I first started to refactor existing > code so that it looks a bit more consistent. I think there is even more > potential to make it smaller, by introducing something similiar to > _nvmet_passthru_target_setup() and _nvmet_passthru_target_cleanup() for non > passthru tests. A lot of duplicated setup/cleanup code in many tests. Thanks for this action :) > > Except the last two patches are just refactoring patches. So if we decide to use > common target setup/cleanup helpers, I think we could add them before the last > two patches, which would make the last patch way smaller. I ran 'make check' and saw shellecheck complaints below. I added 'export' to the variables then they disappeared. tests/nvme/rc:19:1: warning: def_subsysnqn appears unused. Verify use (or export if used externally). [SC2034] tests/nvme/rc:20:1: warning: def_file_path appears unused. Verify use (or export if used externally). [SC2034] tests/nvme/rc:21:1: warning: def_file_path appears unused. Verify use (or export if used externally). [SC2034] I also ran nvme tests with the export fixes and saw no regression. Looks good from test run point of view.
