On Fri, Jul 28, 2023 at 08:20:55AM +0000, Shinichiro Kawasaki wrote: > > Except the last two patches are just refactoring patches. So if we decide to use > > common target setup/cleanup helpers, I think we could add them before the last > > two patches, which would make the last patch way smaller. > > I ran 'make check' and saw shellecheck complaints below. I added 'export' to the > variables then they disappeared. > > tests/nvme/rc:19:1: warning: def_subsysnqn appears unused. Verify use (or export if used externally). [SC2034] > tests/nvme/rc:20:1: warning: def_file_path appears unused. Verify use (or export if used externally). [SC2034] > tests/nvme/rc:21:1: warning: def_file_path appears unused. Verify use (or export if used externally). [SC2034] These variables are not used in nvme/rc at the point I introduce them. Only in the tests. I could add the nvmet setup/cleanup helpers with the variables which would make those warnings go away. But these helpers would then add the end of the series. Also not really good. I don't what is best here. > I also ran nvme tests with the export fixes and saw no regression. Looks good > from test run point of view. Thanks! BTW, I am off next week, so I don't think I send soon an update.
