On 11/17/2016 02:04 PM, Christoph Hellwig wrote:
On Thu, Nov 17, 2016 at 01:30:12PM -0700, Jens Axboe wrote:
The last patch seems to have some issues:
+ bool is_sync = is_sync = is_sync_kiocb(iocb);
and it's reverting part of the dio->is_sync that was part of my union
waiter/iocb change. So I'll leave that out for now, for those reasons.
dio->is_sync isn't needed once the completion handlers are split.
That beeing said I wonder how the above statement even compiled,
there should just be a single assignment obviously.
Did I mention that I don't like the split anyway? :)
Alright alright, let's drop the split ;-)
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
