Re: [PATCH 06/20] mtip32xx: switch to using blk_queue_write_cache()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/12/2016 03:22 PM, Christoph Hellwig wrote:
On Tue, Apr 12, 2016 at 12:36:01PM -0600, Jens Axboe wrote:
Signed-off-by: Jens Axboe <axboe@xxxxxx>
---
  drivers/block/mtip32xx/mtip32xx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 25824c1697c5..6b5c30ff5547 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -4027,7 +4027,7 @@ skip_create_disk:
  	 * write back cache is not supported in the device. FUA depends on
  	 * write back cache support, hence setting flush support to zero.
  	 */
-	blk_queue_flush(dd->queue, 0);
+	blk_queue_write_cache(dd->queue, false, false);

I think this can simply be removed..

Functionally it can, question is if we want to keep it as documentation, or just kill the call and the comment?

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux