Hi, The current interface we have for telling the block layer about the write cache state of the device is a bit odd. The driver calls blk_queue_flush() with a set of flags, with only some combinations being valid. Add blk_queue_write_cache(), which has a clearer interface, and switch drivers to that. Finally, kill off the now unused blk_queue_flush(). Documentation/block/queue-sysfs.txt | 9 ++++ Documentation/block/writeback_cache_control.txt | 4 +- arch/um/drivers/ubd_kern.c | 2 - block/blk-settings.c | 46 +++++++++++++----------- block/blk-sysfs.c | 39 ++++++++++++++++++++ drivers/block/drbd/drbd_main.c | 2 - drivers/block/loop.c | 2 - drivers/block/mtip32xx/mtip32xx.c | 2 - drivers/block/nbd.c | 4 +- drivers/block/osdblk.c | 2 - drivers/block/ps3disk.c | 2 - drivers/block/skd_main.c | 2 - drivers/block/virtio_blk.c | 6 --- drivers/block/xen-blkfront.c | 3 + drivers/ide/ide-disk.c | 6 +-- drivers/md/bcache/super.c | 2 - drivers/md/dm-table.c | 8 ++-- drivers/md/md.c | 2 - drivers/mmc/card/block.c | 2 - drivers/mtd/mtd_blkdevs.c | 2 - drivers/nvme/host/core.c | 3 - drivers/scsi/sd.c | 8 ++-- include/linux/blkdev.h | 4 +- 23 files changed, 107 insertions(+), 55 deletions(-) -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html