On 04/12/2016 03:21 PM, Christoph Hellwig wrote:
On Tue, Apr 12, 2016 at 12:35:58PM -0600, Jens Axboe wrote:
- if (ctrl->vwc & NVME_CTRL_VWC_PRESENT)
- blk_queue_flush(q, REQ_FLUSH | REQ_FUA);
blk_queue_virt_boundary(q, ctrl->page_size - 1);
+ blk_queue_write_cache(q, ctrl->vwc & NVME_CTRL_VWC_PRESENT, true);
fua without the write cache doesn't make sense, I think this should
better use the NVME_CTRL_VWC_PRESENT check for both.
It doesn't really matter, but it doesn't really hurt either. But I'll
just make them both dependent on VWC, that way it's clearer.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-block" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
