On 18-06-21, 12:03, Bjorn Andersson wrote: > On Fri 18 Jun 09:18 CDT 2021, Vinod Koul wrote: > > > GENI_IF_DISABLE_RO is used by geni spi driver as well to check the > > status if GENI, so move this to common header qcom-geni-se.h > > > > Also, add FIFO_IF_DISABLE define. > > > > Afaict these registers relates to the hardware block that is primarily > owned by the individual engine-drivers, would it not make sense to move > them all to the shared header file? the GENI_IF_DISABLE_RO is used by SPI and I2C drivers, so we would create two copies. So better to be defined in geni header -- ~Vinod
