Changes from v3: - Implemented the scheme proposed in my response to Mark in [4]. - Dropped the RFC tag from this patch series as this series has been tested on target with a client driver utilizing these changes. Changes from v2: - Split up framework changes patch for better comprehension. - Dropped PM8008 driver example and converted it into example code in cover letter and commit text. - Added more info in cover letter and commit message as per v2 feedback. This is a follow-up as promised [1] to the earlier attempts [2] [3] to upstream the driver that has been hitherto used to handle IRQs for Qualcomm's PMICs that have multiple on-board peripherals when they are interfaced over the I2C interface. This series is a rewrite of that driver while making use of the regmap-irq framework, which needs some modifications to handle the register layout of Qualcomm's PMICs. This is an RFC because I would like to get feedback on my general approach before submitting as a patch per se. Qualcomm's MFD chips have a top level interrupt status register and sub-irqs (peripherals). When a bit in the main status register goes high, it means that the peripheral corresponding to that bit has an unserviced interrupt. If the bit is not set, this means that the corresponding peripheral does not. The differences between Qualcomm's register layout and what the regmap-irq framework assumes are best described with an example: Suppose that there are three peripherals onboard an MFD chip: MISC, TEMP_ALARM and GPIO01. Each of these peripherals has the following IRQ configuration registers: mask, type and ack. There is a top level interrupt status register and per-peripheral status registers as well (not shown below). The regmap-irq framework expects all similar registers to be at a fixed stride from each other, for each peripheral, as below (with stride = 1). /* All mask registers together */ MISC_INT_MASK 0x1011 TEMP_ALARM_INT_MASK 0x1012 GPIO01_INT_MASK 0x1013 /* All type registers together */ MISC_INT_TYPE 0x2011 TEMP_ALARM_INT_TYPE 0x2012 GPIO01_INT_TYPE 0x2013 /* All ack registers together */ MISC_INT_ACK 0x3011 TEMP_ALARM_INT_ACK 0x3012 GPIO01_INT_ACK 0x3013 In contrast, QCOM's registers are laid out as follows: /* All of MISC peripheral's registers together */ MISC_INT_MASK 0x1011 MISC_INT_TYPE 0x1012 MISC_INT_ACK 0x1013 /* All of TEMP_ALARM peripheral's registers together */ TEMP_ALARM_INT_MASK 0x2011 TEMP_ALARM_INT_TYPE 0x2012 TEMP_ALARM_INT_ACK 0x2013 /* All of GPIO01 peripheral's registers together */ GPIO01_INT_MASK 0x3011 GPIO01_INT_TYPE 0x3012 GPIO01_INT_ACK 0x3013 As is evident, the different IRQ configuration registers are just (0x11, 0x12, 0x13) with offsets of (0x1000, 0x2000 and 0x3000) respectively in QCOM's case. If the *_base registers fed to the struct regmap_irq_chip could be set to the first peripheral (MISC in this example), then through the sub_reg_offsets mechanism, we could add the offsets _to_ the *_base register values to get at the configuration registers for each peripheral. Hopefully this will help when reviewing the changes in this series. [1] https://lore.kernel.org/lkml/20200519185757.GA13992@xxxxxxxxxxxxxx/ [2] https://lore.kernel.org/lkml/cover.1588037638.git.gurus@xxxxxxxxxxxxxx/ [3] https://lore.kernel.org/lkml/cover.1588115326.git.gurus@xxxxxxxxxxxxxx/ [4] https://lore.kernel.org/lkml/20210315203336.GA8977@xxxxxxxxxxxxxx/ Guru Das Srinagesh (2): regmap-irq: Introduce virtual regs to handle more config regs regmap-irq: Add driver callback to configure virtual regs drivers/base/regmap/regmap-irq.c | 43 +++++++++++++++++++++++++++++++++++++++- include/linux/regmap.h | 9 +++++++++ 2 files changed, 51 insertions(+), 1 deletion(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
