Hi Bjorn,
On Thu, Mar 11, 2021 at 04:33:18PM -0800, Bjorn Andersson wrote:
> Enable the modem and WiFi subsystems and specify msm8916 specific
> firmware path for these and the WCNSS control service.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
The changes itself look good to me, but the commit message is really
misleading. It does not mention anywhere that the change actually just
enables "modem" on apq8016-sbc instead of "msm8916". :)
Also, WCNSS was actually enabled before already (with the default
firmware path). In my opinion, it would be clearer to change the
firmware-name for it in an extra patch.
> ---
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 ++++++++++++
> arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> index 6aef0c2e4f0a..448e3561ef63 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> @@ -305,6 +305,12 @@ &mdss {
> status = "okay";
> };
>
> +&mpss {
> + status = "okay";
> +
> + firmware-name = "qcom/msm8916/mba.mbn", "qcom/msm8916/modem.mbn";
> +};
> +
> &pm8916_resin {
> status = "okay";
> linux,code = <KEY_VOLUMEDOWN>;
> @@ -312,6 +318,8 @@ &pm8916_resin {
>
> &pronto {
> status = "okay";
> +
> + firmware-name = "qcom/msm8916/wcnss.mbn";
> };
>
How do I get a .mbn from the wcnss.{mdt,.b??} files provided in the
DB410c firmware package? I guess I should just run them through
https://github.com/andersson/pil-squasher?
Also, is the single file format (mbn) preferred now? Not sure if there
is any significant difference except having less files laying around.
Thanks,
Stephan
