Hi, On Fri, Jul 10, 2020 at 10:11 AM Steev Klimaszewski <steev@xxxxxxxx> wrote: > > > On 7/10/20 9:47 AM, Doug Anderson wrote: > > Hi, > > > > > > But should I continue on this path, > > It's probably worth getting dithering working on your sdm845 anyway in > > case anyone actually does put a 6bpp panel on this SoC. > > > > > >> or should we be finding others who > >> have an N61 and see what their EDID reports? > > I have an email out to BOE, but it might take a little while to get a > > response. I'll see what they say. If they say that the panel > > actually supports 8bpp then it's a no-brainer and we should just > > switch to 8bpp and be done. > > > > ...but if they say it's a 6bpp panel that has its own dither logic > > then it gets more complicated. Initially one would think there should > > be very little downside in defining the panel as an 8bpp panel and > > calling it done. ...except that it conflicts with some other work > > that I have in progress. :-P Specifically if you treat the panel as > > 6bpp and then reduce the blanking a tiny bit you can actually save 75 > > mW of total system power on my board (probably similar on your board > > since you have the same bridge chip). You can see a patch to do that > > here: > > > > https://crrev.com/c/2276384 > > > > ...so I'm hoping to get some clarity from BOE both on the true bits > > per pixel and whether my proposed timings are valid before moving > > forward. Is that OK? > > > > > > -Doug > > > It's fine by me - testing Rob's suggestion of changing > MAX_HDISPLAY_SPLIT 1080->1920 along with the change to adding IS_SDM845 > does give me a full screen that looks nicer, I'm fine with using the > hack locally until a proper solution is found. And I'm always a fan of > using less power on a laptop. > > > I'll give the patch a spin here if you want as well. > > > Hopefully BOE gets back to you soon, and there's no rush, I'm just an > end user who is extremely appreciative of all the work everyone on the > list and the kernel in general put in to make my machines usable. Just FYI that I got confirmation that the panel is truly 6 bpp but it will do FRC dithering if given an 8 bpp input. That means that you should be getting just as good picture quality (and possibly more tunable) by using the dithering in the display pipeline and leaving the panel as 6bpp. Thus I'm going to assume that's the route we'll go down. If ever we find someone that wants to use this panel on a display controller that can't do its own dithering then I guess we'll have to figure out what to do then... In terms of the more optimal pixel clock for saving power, my proposal is still being analyzed and I'll report back when I hear more. I'm seeing if BOE can confirm that my proposal will work both for my panel (the -n62 variant) and the one you have (the -n61 variant). -Doug
