On Tue, Apr 28, 2020 at 10:46:52AM +0530, Sumit Semwal wrote: > On Thu, 13 Jun 2019 at 22:57, Mark Brown <broonie@xxxxxxxxxx> wrote: > > > + /* > > > + * The SC(short circuit) fault would trigger PBS(Portable Batch > > > + * System) to disable regulators for protection. This would > > > + * cause the SC_DETECT status being cleared so that it's not > > > + * able to get the SC fault status. > > > + * Check if LAB/IBB regulators are enabled in the driver but > > > + * disabled in hardware, this means a SC fault had happened > > > + * and SCP handling is completed by PBS. > > > + */ > > Let the core worry about this, the driver should just report the problem > > to the core like all other devices do (and this driver doesn't...). > I (and Bjorn too) looked to find the api that allows us to do this > short circuit reporting and recovery in the core, but couldn't find > anything except REGULATOR_ERROR_OVER_CURRENT which also looks like > it's used only once in the code. A short circuit will generate excessive current (and detection of a short circuit is usually current based) so using the same notification should be fine. If you're concerned about this feel free to add a specific notification, and add any handling you need in response to that notification. You certainly shouldn't be just reenabling the regulators in your driver. Mostly AFAICT people are fairly happy with the autonomous response of the hardware to these issues, it's not like they're expected to happen in normal operation or be recoverable.
Attachment:
signature.asc
Description: PGP signature
