On 07/28, Stephen Boyd wrote: > On 07/28, Rajendra Nayak wrote: > > > > On 07/28/2017 04:21 AM, Stephen Boyd wrote: > > > On 07/20, Rajendra Nayak wrote: > > >> we have gcc_mmss_noc_cfg_ahb_clk marked with a CLK_IGNORE_UNUSED. While > > >> this can prevent it from being disabled while its unused, it does not > > >> prevent it from being disabled when a child derived from the clock calls > > >> an explicit enable/disable. > > > > > > Do you mean the config_noc_clk_src is being disabled? Who is > > > > I think the issue I saw was after I switched the parent from > > config_noc_clk_src to the RPM controlled cnoc_clk. That had to > > be kept voted, else some other ahb clock derived from it being > > disabled was causing the vote on cnoc_clk to be dropped. > > Hmm ok. Maybe we have some sort of bus driver vote from the > multimedia clk driver in downstream code? Let me check. > Ah I was looking at the mmss file when I should have been looking at the gcc file. I see it downstream too, where we call clk_prepare_enable() during gcc boot. This patch looks fine. Eventually, it would make more sense to have this handled by the bus driver, but until we get there this is fine. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
