On Thu, Jul 13, 2017 at 6:02 PM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote: > On 07/13, Rob Clark wrote: >> On Thu, Jul 13, 2017 at 2:09 AM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote: >> > Was device mode working on v4.12? I wonder if we could change >> > dr_mode to host and configure the pmic gpio to mux out the right >> > lines to the hub. Then we could retain host mode on db410c (which >> > is probably all that people care about). It would be a smaller >> > fix for this release while we work out the role switch patches. >> > Like this patch? I still need to test it tomorrow, but this may >> > work and allow us to delete the ehci-msm driver sooner. >> >> yup, was working on v4.12 so this patch that I reverted was a >> regression. At least for host mode. (I don't really use device mode >> much outside of android, so never tried that on v4.12, but it did work >> in the past) > > Ok. > >> >> I can try other patches.. although a bit wary of deleting ehci-msm or >> a big dt change in general since some people seem to think taking dt >> and kernel from two different places is a sane thing) > > I'm fine to leave ehci-msm driver in place for anyone wanting to > use DT from somewhere outside the kernel, just hoping to push > anybody I can towards the chipidea driver, which is a cleaner > solution in the long run. It's scary that we have two usb drivers > operating the same hardware with the DT in v4.12. > > I tested out my patch and it works well enough to get host mode > working for me so I'll send it out as a proper regression fix. > When we add role switching support we'll have to adjust the DT to > support it and people who care to gain support for gadgets can > use the updated DT. > I would mention that robher and jstulz do play with upstream kernel + AOSP.. so I guess some people would care about device mode regressions as well, even though host mode is sufficient for me. So I still lean towards reverting this change for now, and trying again when the mux issues are sorted completely. (I can re-send this revert w/ SoB that I forgot if needed.) BR, -R -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
