On 10/07/2024 19:35, Doug Anderson wrote: > Hi, > > On Wed, Jul 10, 2024 at 10:05 AM Stephan Gerhold > <stephan.gerhold@xxxxxxxxxx> wrote: >> >> The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight >> control over the DP AUX channel. While it works almost correctly with the >> generic "edp-panel" compatible, the backlight needs special handling to >> work correctly. It is similar to the existing ATNA33XC20 panel, just with >> a larger resolution and size. >> >> Add a new "samsung,atna45af01" compatible to describe this panel in the DT. >> >> Signed-off-by: Stephan Gerhold <stephan.gerhold@xxxxxxxxxx> >> --- >> .../devicetree/bindings/display/panel/samsung,atna33xc20.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml >> index 765ca155c83a..d668e8d0d296 100644 >> --- a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml >> +++ b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml >> @@ -14,7 +14,11 @@ allOf: >> >> properties: >> compatible: >> - const: samsung,atna33xc20 >> + enum: >> + # Samsung 13.3" FHD (1920x1080 pixels) eDP AMOLED panel >> + - samsung,atna33xc20 >> + # Samsung 14.5" WQXGA+ (2880x1800 pixels) eDP AMOLED panel >> + - samsung,atna45af01 > > Seems OK, but a few thoughts: > > 1. Is it worth renaming this file? Something like > "samsung,atna-oled-panel.yaml"? I'd be interested in DT maintainer > folks' opinions here. No, rather keep existing name, because it should be based on compatible. Best regards, Krzysztof
