2024. 05. 10. 18:25 keltezéssel, Kathiravan Thirumoorthy írta: > > > On 5/10/2024 12:23 AM, Konrad Dybcio wrote: >> On 9.05.2024 10:08 AM, Gabor Juhos wrote: >>> Since the CONFIG_CTL register is only 32 bits wide in the Stromer >>> and Stromer Plus PLLs , the 'config_ctl_hi_val' values from the >>> IPQ5018 and IPQ5332 configurations are not used so remove those. >>> >>> No functional changes. >>> >>> Signed-off-by: Gabor Juhos <j4g8y7@xxxxxxxxx> >>> --- >> >> Hm, it sounds suspicious that we'd have these settings then.. Could somebody from >> QC please confirm that everything's alright here? > > > I checked the HW doc and yes in both IPQ5018 and IPQ5332 CONFIG_CTL_U register > is not implemented. I see offset of CONFIG_CTL_U register is removed in the > change[1] by Gabor. Thanks for confirming! > > Given that, should we also drop the pll_has_64bit_config() if block from > clk_stromer_pll_configure function? If we can be sure, that there will be no Stromer PLLs which implements that register we can drop the check. Also, since the SUPPORTS_FSM_MODE flag is not set for any of the Stromer (Plus) Plls supported currently, the related check can be dropped as well. However I would keep that as is for now. I'm planning to remove the clk_stromer_pll_configure() function entirely but that needs a bunch of preparatory patches which I'm working on at the moment. > > Nevertheless, for this patch > > Reviewed-by: Kathiravan Thirumoorthy <quic_kathirav@xxxxxxxxxxx> Thank you! Regards, Gabor
