On 5/13/2024 4:56 PM, Krzysztof Kozlowski wrote:
On 13/05/2024 10:47, Tengfei Fan wrote:
All the board dts which base on SM8550 SoC dtsi refer to usb_1_dwc3_ss,
usb_dp_qmpphy_usb_ss_in, orientation-switch and usb-role-switch, so move
them to SoC dtsi from board dts.
That's not really a good argument. Argument is that it is a SoC property
(vs being a property of a board). Provide rationale for that. You are
moving things just because they look common, so to me it looks really
unjustified.
In the next version of the patch series, I will modify the commit
message to more accurately indicate why they need to be moved SoC dtsi.
OTG is default for dr_mode, so it can be dropped from board dts.
Separate patch, see submitting patches.
In the next version of the patch series, I will separate this.
Best regards,
Krzysztof
--
Thx and BRs,
Tengfei Fan
