On 5/10/2024 12:23 AM, Konrad Dybcio wrote:
On 9.05.2024 10:08 AM, Gabor Juhos wrote:
Since the CONFIG_CTL register is only 32 bits wide in the Stromer
and Stromer Plus PLLs , the 'config_ctl_hi_val' values from the
IPQ5018 and IPQ5332 configurations are not used so remove those.
No functional changes.
Signed-off-by: Gabor Juhos <j4g8y7@xxxxxxxxx>
---
Hm, it sounds suspicious that we'd have these settings then.. Could somebody from
QC please confirm that everything's alright here?
I checked the HW doc and yes in both IPQ5018 and IPQ5332 CONFIG_CTL_U
register is not implemented. I see offset of CONFIG_CTL_U register is
removed in the change[1] by Gabor.
Given that, should we also drop the pll_has_64bit_config() if block from
clk_stromer_pll_configure function?
Nevertheless, for this patch
Reviewed-by: Kathiravan Thirumoorthy <quic_kathirav@xxxxxxxxxxx>
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=4f2bc4acbb19
Konrad
