On Mon, Feb 19, 2024 at 8:32 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 17/02/2024 19:32, Bartosz Golaszewski wrote: > > On Sat, Feb 17, 2024 at 4:48 PM Mark Brown <broonie@xxxxxxxxxx> wrote: > >> > >> On Fri, Feb 16, 2024 at 09:32:00PM +0100, Bartosz Golaszewski wrote: > >>> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > >>> > >>> The QCA6390 package contains discreet modules for WLAN and Bluetooth. They > >>> are powered by the Power Management Unit (PMU) that takes inputs from the > >>> host and provides LDO outputs. This document describes this module. > >> > >> Please submit patches using subject lines reflecting the style for the > >> subsystem, this makes it easier for people to identify relevant patches. > >> Look at what existing commits in the area you're changing are doing and > >> make sure your subject lines visually resemble what they're doing. > >> There's no need to resubmit to fix this alone. > > > > Mark, > > > > This is quite vague, could you elaborate? I have no idea what is wrong > > with this patch. > > Use subject prefixes matching the subsystem. You can get them for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching. > > Best regards, > Krzysztof > Yes, I always do. And for Documentation/devicetree/bindings/regulator/ the subjects are split 50:50 between "dt-bindings: regulator: ..." and "regulator: dt-bindings: ...". For Documentation/devicetree/bindings/ it's overwhelmingly "dt-bindings: <subsystem>: ...". It's the first time someone wants me to send a DT bindings patch without "dt-bindings" coming first in the subject. I mean: I can do it alright but it's not stated anywhere explicitly. Bartosz
