Re: [PATCH] clk: qcom: cbf-msm8996: Convert to platform remove callback returning void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hello Stephen,

On Mon, Sep 11, 2023 at 01:02:53PM -0700, Stephen Boyd wrote:
> Quoting Uwe Kleine-König (2023-09-11 08:15:48)
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new() which already returns void. Eventually after all drivers
> > are converted, .remove_new() is renamed to .remove().
> > 
> > qcom_msm8996_cbf_icc_remove() returned zero unconditionally. After
> > changing this function to return void instead, the driver can be
> > converted trivially to use .remove_new().
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > ---
> Do you want to take this? Otherwise, I can apply it to fixes.

if "you" == "Uwe Kleine-König": Please take it via your tree. There is
still much to do before the next synchronous step, so there is no urge.
If the patch goes in during the next merge window that's fine, too.

> > @@ -266,7 +264,7 @@ static int qcom_msm8996_cbf_icc_register(struct platform_device *pdev,  struct c
> >  
> >         return 0;
> >  }
> > -#define qcom_msm8996_cbf_icc_remove(pdev) (0)
> > +#define qcom_msm8996_cbf_icc_remove(pdev) { }
> It would be better if this was a static inline function.

Ack, but this applies to the state before my patch, too, and I think
this should be addressed separately. That's currently not in my focus,
so if someone else wants to address this, you're welcome.

Best regards

Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | |

Attachment: signature.asc
Description: PGP signature

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux