Re: [RESEND PATCH v6 0/3] Add support for vibrator in multiple PMICs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Can anyone help to review the driver changes?

Fenglin Wu

On 8/28/2023 1:32 PM, Fenglin Wu wrote:
Add SW support for the vibrator module inside PMI632, PM7250B, PM7325B, PM7550BA.
It is very similar to the vibrator module inside PM8916 which is supported in
pm8xxx-vib driver but just the drive amplitude is controlled with 2 registers,
and the register base offset in each PMIC is different.

Changes in v6:
   1. Add "qcom,pmi632-vib" as a standalone compatible string.

Changes in v5:
   1. Drop "qcom,spmi-vib-gen2" generic compatible string as requested
      and use device specific compatible strings only.

Changes in v4:
   1. Update to use the combination of the HW type and register offset
      as the constant match data, the register base address defined in
      'reg' property will be added when accessing SPMI registers using
      regmap APIs.
   2. Remove 'qcom,spmi-vib-gen1' generic compatible string.

Changes in v3:
   1. Refactor the driver to support different type of the vibrators with
     better flexibility by introducing the HW type with corresponding
     register fields definitions.
   2. Add 'qcom,spmi-vib-gen1' and 'qcom,spmi-vib-gen2' compatible
     strings, and add PMI632, PM7250B, PM7325B, PM7550BA as compatbile as

Changes in v2:
   Remove the "pm7550ba-vib" compatible string as it's compatible with pm7325b.

Fenglin Wu (3):
   input: pm8xxx-vib: refactor to easily support new SPMI vibrator
   dt-bindings: input: qcom,pm8xxx-vib: add new SPMI vibrator module
   input: pm8xxx-vibrator: add new SPMI vibrator support

  .../bindings/input/qcom,pm8xxx-vib.yaml       |  16 +-
  drivers/input/misc/pm8xxx-vibrator.c          | 171 ++++++++++++------
  2 files changed, 132 insertions(+), 55 deletions(-)

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux