On 16.06.2023 10:32, Sridharan S N wrote: > Add support for wlan-2g LED on GPIO 36 and wps buttons on GPIO 35. > > Signed-off-by: Sridharan S N <quic_sridsn@xxxxxxxxxxx> > --- > Changes in V4: > - Added patch dependency. This change depends on below patch set > https://lore.kernel.org/linux-arm-msm/20230615090001.10970-1-quic_sridsn@xxxxxxxxxxx/ > > Changes in V3: > - Updated patch series title. Mentioned platform in series > title > > Changes in V2: > - Used the hypen in node name instead of underscore > - Dropped the status property > > .../boot/dts/qcom/ipq5332-rdp-common.dtsi | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi > index 97dc0e5c15f0..a8671a4ac2e4 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp-common.dtsi > @@ -19,6 +19,31 @@ > chosen { > stdout-path = "serial0"; > }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-0 = <&gpio_keys_default>; > + pinctrl-names = "default"; > + > + button-wps { > + label = "wps"; > + linux,code = <KEY_WPS_BUTTON>; > + gpios = <&tlmm 35 GPIO_ACTIVE_LOW>; > + debounce-interval = <60>; That's purely your choice, but don't you wanna make it wakeup-capable? Otherwise: Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + pinctrl-0 = <&gpio_leds_default>; > + pinctrl-names = "default"; > + > + led-0 { > + gpios = <&tlmm 36 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "phy0tx"; > + default-state = "off"; > + }; > + }; > }; > > &blsp1_i2c1 { > @@ -52,6 +77,20 @@ > /* PINCTRL */ > > &tlmm { > + gpio_keys_default: gpio-keys-default-state { > + pins = "gpio35"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + > + gpio_leds_default: gpio-leds-default-state { > + pins = "gpio36"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-down; > + }; > + > i2c_1_pins: i2c-1-state { > pins = "gpio29", "gpio30"; > function = "blsp1_i2c0";
