On 10.04.2023 20:10, Krzysztof Kozlowski wrote: > Pin configuration property "input-enable" was used with the intention to > disable the output, but this is done by default by Linux drivers. Since > patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not > input-enable") the property is not accepted anymore. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad > arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 -- > arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi | 1 - > arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts | 1 - > arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts | 4 ---- > .../boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts | 1 - > 5 files changed, 9 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts > index ab35f2d644c0..861695cecf84 100644 > --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts > +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts > @@ -592,7 +592,6 @@ mpu6515_pin: mpu6515-state { > pins = "gpio73"; > function = "gpio"; > bias-disable; > - input-enable; > }; > > touch_pin: touch-state { > @@ -602,7 +601,6 @@ int-pins { > > drive-strength = <2>; > bias-disable; > - input-enable; > }; > > reset-pins { > diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi > index d3bec03b126c..68a2f9094e53 100644 > --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi > @@ -433,7 +433,6 @@ ts_int_pin: touch-int-state { > function = "gpio"; > drive-strength = <2>; > bias-disable; > - input-enable; > }; > > sdc1_on: sdc1-on-state { > diff --git a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts > index 8d2a054d8fee..8230d0e1d95d 100644 > --- a/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts > +++ b/arch/arm/boot/dts/qcom-msm8974pro-oneplus-bacon.dts > @@ -461,7 +461,6 @@ int-pins { > function = "gpio"; > drive-strength = <2>; > bias-disable; > - input-enable; > }; > > reset-pins { > diff --git a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts > index b9698ffb66ca..eb505d6d7f31 100644 > --- a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts > +++ b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts > @@ -704,7 +704,6 @@ hostwake-pins { > pins = "gpio75"; > function = "gpio"; > drive-strength = <16>; > - input-enable; > }; > > devwake-pins { > @@ -760,14 +759,12 @@ cmd-data-pins { > i2c_touchkey_pins: i2c-touchkey-state { > pins = "gpio95", "gpio96"; > function = "gpio"; > - input-enable; > bias-pull-up; > }; > > i2c_led_gpioex_pins: i2c-led-gpioex-state { > pins = "gpio120", "gpio121"; > function = "gpio"; > - input-enable; > bias-pull-down; > }; > > @@ -781,7 +778,6 @@ gpioex_pin: gpioex-state { > wifi_pin: wifi-state { > pins = "gpio92"; > function = "gpio"; > - input-enable; > bias-pull-down; > }; > > diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts > index 04bc58d87abf..0f650ed31005 100644 > --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts > +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts > @@ -631,7 +631,6 @@ ts_int_pin: ts-int-pin-state { > function = "gpio"; > drive-strength = <2>; > bias-disable; > - input-enable; > }; > > bt_host_wake_pin: bt-host-wake-state {