Hi Gilad, On Thu, 2015-02-19 at 15:54 -0700, Gilad Avidov wrote: > > + > +static u32 pmic_arb_fmt_cmd_v1(u8 opc, u8 sid, u16 addr, u8 bc) > +{ > + return (opc << 27) | ((sid & 0xf) << 20) | (addr << 4) | (bc & 0x7); > +} > + > +static u32 pmic_arb_fmt_cmd_v2(u8 opc, u8 sid, u16 addr, u8 bc) > +{ > + return (opc << 27) | ((addr & 0xff) << 4) | (bc & 0x7); This one is looking suspicious. Address could be only 8 bits? Slave ID is not used? Is this correct? Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html