On 07/16/2014 01:39 PM, pramod.gurav.etc@xxxxxxxxx wrote:
From: Pramod Gurav <pramod.gurav.etc@xxxxxxxxx> REGMAP_SPMI module calls some functions from SPMI hence build breaks when SPMI is not enabled while compiling REGMAP_SPMI with below linker errors: drivers/built-in.o: In function `regmap_spmi_ext_read': :(.text+0x1143ec): undefined reference to `spmi_ext_register_read' :(.text+0x11443c): undefined reference to `spmi_ext_register_readl' drivers/built-in.o: In function `regmap_spmi_ext_gather_write': :(.text+0x1144c4): undefined reference to `spmi_ext_register_write' :(.text+0x114520): undefined reference to `spmi_ext_register_writel' drivers/built-in.o: In function `regmap_spmi_base_read': :(.text+0x1145b8): undefined reference to `spmi_register_read' drivers/built-in.o: In function `regmap_spmi_base_gather_write': :(.text+0x114630): undefined reference to `spmi_register_write' :(.text+0x11465c): undefined reference to `spmi_register_zero_write' Signed-off-by: Pramod Gurav <pramod.gurav.etc@xxxxxxxxx> CC: Josh Cartwright <joshc@xxxxxxxxxxxxxx> CC: Mark Brown <broonie@xxxxxxxxxx> --- This was found when I enabled support for Qualcomm QPNP PMICs and was compiling it. It selects REGMAP_SPMI and hence the crash.
Any driver that does select REGMAP_SPMI needs to depends on SPMI. So the correct fix for this issue is to make sure that the driver can only be enabled if SPMI is enabled.
- Lars -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html