On 07/01/14 09:32, Viresh Kumar wrote: > +static int cpu0_cpufreq_init(struct cpufreq_policy *policy) > +{ > + struct cpufreq_frequency_table *freq_table; > + struct thermal_cooling_device *cdev; This.. > + struct device_node *np; > + struct private_data *priv; > + [...] > ing them. > @@ -223,28 +242,92 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev) > "running cpufreq without cooling device: %ld\n", > PTR_ERR(cdev)); > } > - > of_node_put(np); > + > + priv->cdev = cdev; Causes a build warning: drivers/cpufreq/cpufreq-generic.c:313:13: warning: 'cdev' may be used uninitialized in this function [-Wmaybe-uninitialized] So I guess we should initialize it to NULL? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html