On 1 July 2014 23:30, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote: > On 07/01/14 09:32, Viresh Kumar wrote: >> Create a new routine of_clk_shared_by_cpus() that finds if clock lines are >> shared between two CPUs. This is verified by comparing "clocks" property from >> CPU's DT node. >> >> Returns 1 if clock line is shared between them, 0 if clock isn't shared and >> return appropriate errors in case nodes/properties are missing. >> >> Cc: Mike Turquette <mturquette@xxxxxxxxxx> >> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> >> --- >> drivers/clk/clk.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++++ >> include/linux/clk.h | 6 ++++++ > > This doesn't make much sense to me. This function doesn't deal with > struct clk pointers or any of the internals of the common clock > framework so why put it in clk.c? It looks more like an internal > function that the cpufreq-generic driver should have. I thought this is what Rob suggested when he said: "I think a clock api function would be better." I had it in cpufreq-cpu0 driver earlier and moved it to a separate API yesterday only. Sorry if I misunderstood his comment. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
