On Jun 12, 2014, at 2:50 PM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote: > On 06/12/14 12:13, Kumar Gala wrote: >> +static int qcom_ahci_probe(struct platform_device *pdev) >> +{ >> + struct ahci_host_priv *hpriv; >> + struct clk *rxoob_clk; >> + int rc; >> + >> + hpriv = ahci_platform_get_resources(pdev); >> + if (IS_ERR(hpriv)) >> + return PTR_ERR(hpriv); >> + >> + /* Try and set the rxoob clk to 100Mhz */ >> + rxoob_clk = of_clk_get_by_name(pdev->dev.of_node, "rxoob"); > > Any reason we can't use devm_clk_get() here? Was trying to avoid the ref cnt of devm_clk_get() as the clk’s are actually handled in ahci_platform_get_resources/ahci_platform_enable_resources - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html