On Fri, 2010-10-29 at 18:53 -0400, Nicolas Pitre wrote: > On Fri, 29 Oct 2010, Daniel Walker wrote: > > > On Fri, 2010-10-29 at 18:17 -0400, Nicolas Pitre wrote: > > > > > Could you at least comment the patch I posted for you? > > > > I didn't see anything wrong with it, not from an MSM perspective. > > So now you have two possibilities: my patch, or Russell's suggestions. > Personally I find my patch is slightly better in the sense that it > doesn't make use of a magic 0xfff00000 value with no obvious semantic. > But you have the choice. Russell's because I think I can get that in right now, which is all I care about. > > I'd like to have MSM building before -rc1 , that's why I was suggesting > > I go with my original revert then we would fix this issue during the -rc > > cycle. > > y > Your "fix" is just as broken as the current compilation problem. Sure > with your revert you may compile a kernel, but that kernel may as well > crash at run time instead. The build issue is a little more dire I think, I never suggested my revert fixed anything but the build issue (which was the point) .. It was just suppose to bring back what was wrongfully removed. Daniel -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html