Re: [PATCH] msm: fix debug-macro.S build failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 27 Oct 2010, Russell King - ARM Linux wrote:

> > +#else
> > +	.macro	addruart, rx, tmp
> 
> addruart is now expected to return two values, and 'tmp' ends up being
> misleading.  This is a recipe for mistakes unless this is corrected.
> It should be 'rp, rv' instead of 'rx, tmp'.

Also, it is probably not a good idea to return nothing. Otherwise the 
code using those macros will then work on random values that just 
happened to be in the corresponding register at the call location.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux