On Fri, 29 Oct 2010, Daniel Walker wrote: > On Fri, 2010-10-29 at 18:17 -0400, Nicolas Pitre wrote: > > > Could you at least comment the patch I posted for you? > > I didn't see anything wrong with it, not from an MSM perspective. So now you have two possibilities: my patch, or Russell's suggestions. Personally I find my patch is slightly better in the sense that it doesn't make use of a magic 0xfff00000 value with no obvious semantic. But you have the choice. > I'd like to have MSM building before -rc1 , that's why I was suggesting > I go with my original revert then we would fix this issue during the -rc > cycle. y Your "fix" is just as broken as the current compilation problem. Sure with your revert you may compile a kernel, but that kernel may as well crash at run time instead. Nicolas -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
