> On Mon, 2010-08-09 at 20:42 -0700, stepanm@xxxxxxxxxxxxxx wrote: > I believe the current uses of pr_err in this module > are unnecessary or could be converted to pr_debug. > > I think __func__/line aren't particularly useful. > > I prefer log messages prefixed with the module name. > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > and I'd convert all the current pr_err to pr_debug > and convert the printk(KERN_ERR to pr_err( > > cheers, Joe Thanks. Fixed in v4, which will go up in a few minutes. -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
