On Mon, 2010-08-09 at 20:42 -0700, stepanm@xxxxxxxxxxxxxx wrote: > I am actually considering doing away with all the pr_err lines entirely > because they typically also result in returning -Ewhatever and other IOMMU > drivers don't give this level of error reporting. But, they may be helpful > to the users of the API. What are people's thoughts on this? I believe the current uses of pr_err in this module are unnecessary or could be converted to pr_debug. I think __func__/line aren't particularly useful. I prefer log messages prefixed with the module name. #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt and I'd convert all the current pr_err to pr_debug and convert the printk(KERN_ERR to pr_err( cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
