On 10/11/18, Eugene Syromiatnikov <esyr@xxxxxxxxxx> wrote: > On Thu, Oct 11, 2018 at 09:24:43AM +0200, Arnd Bergmann wrote: >> On Thu, Oct 11, 2018 at 6:26 AM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote: > >> > +# pkey_mprotect requires an architecture specific implementation >> > +328 common pkey_mprotect sys_pkey_mprotect >> > +# pkey_alloc requires an architecture specific implementation >> > +329 common pkey_alloc sys_pkey_alloc >> > +# pkey_free requires an architecture specific implementation >> > +330 common pkey_free sys_pkey_free >> >> One comment for all pkey calls would be sufficient. More importantly >> it requires hardware support that ia64 does not have AFAICT. > > Except it has[1]. > Ok, then we should definitely assign the system call numbers. Arnd