On Thu, Oct 11, 2018 at 09:24:43AM +0200, Arnd Bergmann wrote: > On Thu, Oct 11, 2018 at 6:26 AM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote: > > +# perf_event_open requires an architecture specific implementation > > +326 common perf_event_open sys_perf_event_open [...] > > I don't think that's correct for these two. perf_event_open() of > course requires 'perf' support that ia64 does not have That's actuallt quite funny, given the fact that IA-64 has perfmonctl() which likely was the precursor of current perf infractructure. > > +# pkey_mprotect requires an architecture specific implementation > > +328 common pkey_mprotect sys_pkey_mprotect > > +# pkey_alloc requires an architecture specific implementation > > +329 common pkey_alloc sys_pkey_alloc > > +# pkey_free requires an architecture specific implementation > > +330 common pkey_free sys_pkey_free > > One comment for all pkey calls would be sufficient. More importantly > it requires hardware support that ia64 does not have AFAICT. Except it has[1]. [1] https://www.thailand.intel.com/content/dam/www/public/us/en/documents/manuals/itanium-architecture-software-developer-rev-2-3-vol-2-manual.pdf#page=78
