On Tue, 2010-03-23 at 11:42 +0100, Ingo Molnar wrote: > * Yinghai Lu <yinghai@xxxxxxxxxx> wrote: > > > void __init lmb_init(void) > > { > > + lmb.memory.region = lmb_memory_region; > > + lmb.memory.region_array_size = ARRAY_SIZE(lmb_memory_region); > > + lmb.reserved.region = lmb_reserved_region; > > + lmb.reserved.region_array_size = ARRAY_SIZE(lmb_reserved_region); > > + > > That's rather unreadable and has random whitespace noise. > > Should be something like: > > lmb.memory.region = lmb_memory_region; > lmb.memory.region_array_size = ARRAY_SIZE(lmb_memory_region); > lmb.reserved.region = lmb_reserved_region; > lmb.reserved.region_array_size = ARRAY_SIZE(lmb_reserved_region); > > also, i'd suggest to shorten region_array_size to region_size (we know it's an > array), so it would become: I dislike those arrays anyways. See my other message about turning them into lists, which would get rid of capacity constraints completely. What do you think ? Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html