* Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> void __init lmb_init(void)
> {
> + lmb.memory.region = lmb_memory_region;
> + lmb.memory.region_array_size = ARRAY_SIZE(lmb_memory_region);
> + lmb.reserved.region = lmb_reserved_region;
> + lmb.reserved.region_array_size = ARRAY_SIZE(lmb_reserved_region);
> +
That's rather unreadable and has random whitespace noise.
Should be something like:
lmb.memory.region = lmb_memory_region;
lmb.memory.region_array_size = ARRAY_SIZE(lmb_memory_region);
lmb.reserved.region = lmb_reserved_region;
lmb.reserved.region_array_size = ARRAY_SIZE(lmb_reserved_region);
also, i'd suggest to shorten region_array_size to region_size (we know it's an
array), so it would become:
lmb.memory.region = lmb_memory_region;
lmb.memory.region_size = ARRAY_SIZE(lmb_memory_region);
lmb.reserved.region = lmb_reserved_region;
lmb.reserved.region_size = ARRAY_SIZE(lmb_reserved_region);
> - if (rgn->cnt >= MAX_LMB_REGIONS)
> + if (rgn->cnt >= (rgn->region_array_size - 1))
> return -1;
'x >= y-1' is equivalent to 'x > y', so that should be:
if (rgn->cnt > rgn->region_size)
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
