On Fri, 15 Aug 2008, Felipe Balbi wrote:
> On Fri, Aug 15, 2008 at 03:38:49PM +0300, Felipe Balbi wrote:
> +#ifndef writesl
> static inline void writesl(const void __iomem *addr, const void *buf, int len)
> { outsl((unsigned long)addr, buf, len); }
> +#endif
> +#ifndef writesw
> static inline void writesw(const void __iomem *addr, const void *buf, int len)
> { outsw((unsigned long)addr, buf, len); }
> +#endif
> +#ifndef writesb
> static inline void writesb(const void __iomem *addr, const void *buf, int len)
> { outsb((unsigned long)addr, buf, len); }
> -
> #endif
... which may cause silent memory corruption when somebody enables this
driver on a platform where the above routines don't do what they should
do?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
