Re: drivers/usb/musb/musb_io.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 15 August 2008, David Brownell wrote:
> Someone commented that this is what caused creation of
> the mmio_insl() family of routines ...
> 
> ... but I notice that at least on ARM (current primary home
> for this driver!) those calls don't end up using optimized
> code. Since those optimimzed loops are a *big* win in terms
> of performance -- using LDM/STM to burst memory acccess to/from
> registers -- I'd rather not go that way for now.

Oh, and worth remembering:  *WHEN* a clean solution for this
is available, it should be usable in the NAND code.  And surely
in other places which sometimes need PIO access to a FIFO...

I was surprised to see that 16% improvement in read performance
with an 8-bit NAND device, just by switching from code looking
like generic mmio_insb() over to __raw_readsb().  Better IMO to
have the faster code be what the NAND core uses by default, than
to need to modify every platform's NAND driver to do that.

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux