On Friday 15 August 2008, Felipe Balbi wrote:
> Hmm... but how about the other version?
>
> +#ifndef readsl
> static inline void readsl(const void __iomem *addr, void *buf, int len)
> { insl((unsigned long)addr, buf, len); }
> +#endif
> +#ifndef readsw
> static inline void readsw(const void __iomem *addr, void *buf, int len)
> { insw((unsigned long)addr, buf, len); }
> +#endif
Any arch defining an inline readsl() etc will break. And
inlines are the preferred style lately. :)
Someone commented that this is what caused creation of
the mmio_insl() family of routines ...
... but I notice that at least on ARM (current primary home
for this driver!) those calls don't end up using optimized
code. Since those optimimzed loops are a *big* win in terms
of performance -- using LDM/STM to burst memory acccess to/from
registers -- I'd rather not go that way for now.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
