On Mon, 28 Jul 2008 19:19:44 +0200 Andrea Righi <righi.andrea@xxxxxxxxx> wrote: > KOSAKI Motohiro wrote: > >> yep! clear. > >> > >> Ok, in this case wouldn't be better at least to define pud_free() as: > >> > >> static inline pud_free(struct mm_struct *mm, pmd_t *pmd) > >> { > >> } > > > > I also like this :) > > ok, a simpler patch using the inline function will follow. > I can second that. See http://userweb.kernel.org/~akpm/mmotm/broken-out/include-asm-generic-pgtable-nopmdh-macros-are-noxious-reason-435.patch Ingo cruelly ignored it. Probably he's used to ignoring the comit storm which I send in his direction - I'll need to resend it sometime. I'd consider that patch to be partial - we should demacroize the surrounding similar functions too. But that will require a bit more testing. -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html