Linus Torvalds wrote: > > On Mon, 28 Jul 2008, Andrea Righi wrote: >> Move multiple definitions of pmd_free() from different include/asm-* into >> mm/util.c. > > But this is horrible, because it forces a totally unnecessary function > call for that empty function. > > Yeah, the function will be cheap, but the call itself will not be (it's a > C language barrier and basically disables optimizations around it, causing > thigns like register spill/reload for no good reason). > > Linus yep! clear. Ok, in this case wouldn't be better at least to define pud_free() as: static inline pud_free(struct mm_struct *mm, pmd_t *pmd) { } in include/asm-generic/pgtable-nopmd.h, just to avoid the warning on x86 without PAE? Thanks for the explanation, -Andrea -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html