Re: [PATCH v4 23/24] fpga: dfl: afu: add user afu sub feature support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 20, 2018 at 01:17:14PM -0500, Alan Tull wrote:
> On Tue, Mar 20, 2018 at 2:10 AM, Wu Hao <hao.wu@xxxxxxxxx> wrote:
> > On Mon, Mar 19, 2018 at 03:10:28PM -0500, Alan Tull wrote:
> >> On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao <hao.wu@xxxxxxxxx> wrote:
> >>
> >> Hi Hao,
> >>
> >> > From: Xiao Guangrong <guangrong.xiao@xxxxxxxxxxxxxxx>
> >> >
> >> > User Accelerated Function Unit sub feature exposes the MMIO region of
> >>
> >> Is it 'user accelerated'?  I think it is the Accelerator interface.
> >
> > Hi Alan,
> >
> > This is only used to emphasize this is the interface to accelerator
> > exposed to user. But looks like this causes some confusions for user
> > actually from the description. I agree with you, that I will remove
> > this UAFU from this patchset.
> >
> >>
> >> > the AFU. After valid green bitstream (GBS) is programmed and port is
> >>
> >> Would it make sense to just use "partial bitstream" or "PR bitstream"
> >> and "static bitstream" for this patchset?  I don't think that adding
> >> this terminology makes things clearer.  In any case when someone else
> >> uses this patchset, they may not be using this type of branding in
> >> their terminology.
> >
> > Sure, will update the commit message and also sysfs doc below.
> 
> Yes and dfl.txt and the rest of the patchset as well, please.

Sure, I understand that it may have different PR hardwares under this
framework, each PR hardware may have a different terminology for its own
bitstream. We should use common terminology in the common doc and code
to avoid confusion. Thanks for the reminder. I will fix this.

Thanks
Hao

> 
> Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux