On Wed, Jun 24, 2015 at 03:25:57PM +0900, Sergey Senozhatsky wrote:
> On (06/24/15 06:10), Seymour, Shane M wrote:
> [..]
> >
> > /* The sysfs driver interface. Read-only at the moment */
> > -static ssize_t st_try_direct_io_show(struct device_driver *ddp, char *buf)
> > +static ssize_t try_direct_io_show(struct device_driver *ddp, char *buf)
> > {
> > - return snprintf(buf, PAGE_SIZE, "%d\n", try_direct_io);
> > + return sprintf(buf, "%d\n", try_direct_io);
> > }
>
> a nitpick,
>
> per Documentation/filesystems/sysfs.txt
>
> :
> : - show() should always use scnprintf().
> :
That should be rewritten to say, "don't use snprintf(), but scnprintf(),
if you want to. Otherwise sprintf() should be fine as you obviously are
only returning a single value to userspace"
Or something like that.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
