On (06/24/15 06:10), Seymour, Shane M wrote:
[..]
>
> /* The sysfs driver interface. Read-only at the moment */
> -static ssize_t st_try_direct_io_show(struct device_driver *ddp, char *buf)
> +static ssize_t try_direct_io_show(struct device_driver *ddp, char *buf)
> {
> - return snprintf(buf, PAGE_SIZE, "%d\n", try_direct_io);
> + return sprintf(buf, "%d\n", try_direct_io);
> }
a nitpick,
per Documentation/filesystems/sysfs.txt
:
: - show() should always use scnprintf().
:
-ss
> -static DRIVER_ATTR(try_direct_io, S_IRUGO, st_try_direct_io_show, NULL);
> +static DRIVER_ATTR_RO(try_direct_io);
>
> -static ssize_t st_fixed_buffer_size_show(struct device_driver *ddp, char *buf)
> +static ssize_t fixed_buffer_size_show(struct device_driver *ddp, char *buf)
> {
> - return snprintf(buf, PAGE_SIZE, "%d\n", st_fixed_buffer_size);
> + return sprintf(buf, "%d\n", st_fixed_buffer_size);
> }
> -static DRIVER_ATTR(fixed_buffer_size, S_IRUGO, st_fixed_buffer_size_show, NULL);
> +static DRIVER_ATTR_RO(fixed_buffer_size);
>
> -static ssize_t st_max_sg_segs_show(struct device_driver *ddp, char *buf)
> +static ssize_t max_sg_segs_show(struct device_driver *ddp, char *buf)
> {
> - return snprintf(buf, PAGE_SIZE, "%d\n", st_max_sg_segs);
> + return sprintf(buf, "%d\n", st_max_sg_segs);
> }
> -static DRIVER_ATTR(max_sg_segs, S_IRUGO, st_max_sg_segs_show, NULL);
> +static DRIVER_ATTR_RO(max_sg_segs);
>
> -static ssize_t st_version_show(struct device_driver *ddd, char *buf)
> +static ssize_t version_show(struct device_driver *ddd, char *buf)
> {
> - return snprintf(buf, PAGE_SIZE, "[%s]\n", verstr);
> + return sprintf(buf, "[%s]\n", verstr);
> }
> -static DRIVER_ATTR(version, S_IRUGO, st_version_show, NULL);
> +static DRIVER_ATTR_RO(version);
>
> static struct attribute *st_drv_attrs[] = {
> &driver_attr_try_direct_io.attr,
> --
--
To unsubscribe from this list: send the line "unsubscribe linux-api" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
