On Wed, Jan 12, 2011 at 10:02 PM, Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx> wrote: > Interrupts ought to be disabled _before_ irq_enter(). > > Signed-off-by: Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx> > > diff --git a/arch/alpha/kernel/irq.c b/arch/alpha/kernel/irq.c > index 5912900..9ab234f 100644 > --- a/arch/alpha/kernel/irq.c > +++ b/arch/alpha/kernel/irq.c > @@ -160,15 +160,14 @@ handle_irq(int irq) > return; > } > > - irq_enter(); > /* > - * handle_irq() must be called with IPL_MAX. Note that we do not > + * From here we must proceed with IPL_MAX. Note that we do not > * explicitly enable interrupts afterwards - some MILO PALcode > * (namely LX164 one) seems to have severe problems with RTI > * at IPL 0. > */ > local_irq_disable(); > + irq_enter(); > generic_handle_irq_desc(irq, desc); > irq_exit(); > } > - Thanks! Applied. Matt -- To unsubscribe from this list: send the line "unsubscribe linux-alpha" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
