Hi, On 1/5/21 6:18 PM, Rafael J. Wysocki wrote: > On Mon, Jan 4, 2021 at 9:58 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: <snip> >> Patch 1/2 does use a slightly different approach then I suggest above, >> thinking more about this it would be cleaner IMHO to just pass the >> cur_profile pointer to the callbacks as the pseudo-code patch which I >> wrote above does. Drivers which use globals can then just ignore >> the extra argument (and keep the platform_profile_handler struct const) >> where as drivers which use dynamic allocation can embed the struct in >> their driver's data-struct. > > Agreed. Note that Jiaxun has provided a v2 of this patch-set with patch 1/2 implementing the new approach. Can you merge merge that patch please and then once you're happy that this has seen enough exposure in -next, provide me with an immutable branch with the 3 platform-profile patches in it ? Regards, Hans
